Skip to content

Update topic slugs in AAQ #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

akatsoulas
Copy link
Collaborator

No description provided.

@akatsoulas akatsoulas force-pushed the update-question-topics branch 2 times, most recently from 9924ff1 to 9f667f8 Compare June 26, 2024 13:46
@akatsoulas akatsoulas marked this pull request as ready for review June 26, 2024 13:46
@akatsoulas
Copy link
Collaborator Author

@escattone this is ready for a review. Could you have a go?

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think two of the names still need to be made consistent with the others?

"name": _lazy("Customize controls, options and add-ons"),
"topic": "customize",
"tags": ["customize"],
"name": _lazy("Customize settings and Preferences"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, the Preferences should be lowercase, so preferences.

Comment on lines 63 to 65
"name": _lazy(
"Fix slowness, crashing, error messages and " "other problems"
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still valid isn't it? Doesn't this need to change to Troubleshooting?

@akatsoulas akatsoulas force-pushed the update-question-topics branch from 9f667f8 to e842f0c Compare June 26, 2024 14:27
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akatsoulas!

@akatsoulas akatsoulas force-pushed the update-question-topics branch from e842f0c to 4d2ed70 Compare June 26, 2024 15:02
@akatsoulas akatsoulas force-pushed the update-question-topics branch from 4d2ed70 to 94e4d6f Compare June 26, 2024 15:35
@akatsoulas akatsoulas merged commit fbf9d0d into mozilla:main Jun 26, 2024
2 checks passed
@akatsoulas akatsoulas deleted the update-question-topics branch June 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants